Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignoreNoDocuments option usage when using graphql configs #9371

Merged
merged 4 commits into from
May 11, 2023

Conversation

Axxxx0n
Copy link
Contributor

@Axxxx0n Axxxx0n commented May 6, 2023

Description

When using general graphql configs (eg. graphql.config.json) instead of codegen configs (eg. codegen.ts), ignoreNoDocuments option and CLI flag are not working. Additional guard was added when loading documents to not throw error when ignoreNoDocuments option is needed.

Related # (issue)
#9368

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

added additional test

Test Environment:

  • OS: MacOS
  • @graphql-codegen/...: @latest
  • NodeJS: 18

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented May 6, 2023

🦋 Changeset detected

Latest commit: 2548648

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Axxxx0n Axxxx0n changed the title fix ignoreNoDocuments option usage when using graphql configs fix: ignoreNoDocuments option usage when using graphql configs May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants