Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup cronjob must support istio during startup #93

Merged
merged 3 commits into from
Apr 10, 2023
Merged

Conversation

steved
Copy link
Contributor

@steved steved commented Apr 10, 2023

To properly work with Istio, the cronjob must be able to wait for the proxy sidecar to start and then call /quitquitquit at exit.

@steved steved force-pushed the steved/cronjob-istio branch from 6fdc18c to e046a9a Compare April 10, 2023 21:09
@steved
Copy link
Contributor Author

steved commented Apr 10, 2023

/functional-test


Launched workflow: Functional tests

@steved steved force-pushed the steved/cronjob-istio branch from e046a9a to b61d442 Compare April 10, 2023 22:08
@steved steved marked this pull request as ready for review April 10, 2023 22:11
@steved steved requested a review from JadeHayes April 10, 2023 22:11
Copy link
Contributor

@JadeHayes JadeHayes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you! Didn't realize istio needed special configuration

@steved steved merged commit 02f565d into main Apr 10, 2023
@steved steved deleted the steved/cronjob-istio branch April 10, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants