Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-5981: clarify error message when registry validation fails on an image build #100

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

ddl-kfrench
Copy link
Contributor

@ddl-kfrench ddl-kfrench commented Jun 12, 2023

as we can't establish a definitive 1:1 correlation between the server field in registry auth and the computed docker config.json in downstream authentication, this adds a helpMessage str slice to store general metadata about the credentials supplied to an imagebuild that can be leveraged in any error message(s) related to failed registry authentication.

@ddl-kfrench ddl-kfrench marked this pull request as ready for review June 12, 2023 22:41
@ddl-kfrench ddl-kfrench requested a review from steved as a code owner June 12, 2023 22:41
@ddl-kfrench
Copy link
Contributor Author

ddl-kfrench commented Jun 13, 2023

/functional-test


Launched workflow: Functional tests

@ddl-kfrench
Copy link
Contributor Author

ddl-kfrench commented Jun 14, 2023

/functional-test


Launched workflow: Functional tests

Copy link
Contributor

@steved steved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nitpicks around wording so merge when you feel comfortable. Thanks!

@ddl-kfrench ddl-kfrench merged commit 9f37dea into main Jun 16, 2023
@ddl-kfrench ddl-kfrench deleted the kfrench/PLAT-5981 branch June 16, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants