-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DBAL-1090] Changing string to fixed string is not recognized in PostgreSQL Platform #754
[DBAL-1090] Changing string to fixed string is not recognized in PostgreSQL Platform #754
Conversation
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1090 We use Jira to track the state of pull requests and the versions they got |
$tableDiff = new TableDiff('mytable'); | ||
$tableDiff->fromTable = $table; | ||
|
||
$tableDiff->changedColumns['dloo1'] = new \Doctrine\DBAL\Schema\ColumnDiff( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why dloo1
? Shouldn't it be name
also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must confess: I did evil copy paste. There's the reason why copy paste is an anti-pattern.
@SenseException could you please make the new test case run on all platforms? You should put it into |
@deeky666 I moved the test to AbstractPlatformTestCase and changed it into the style of the other test cases. It looks like DrizzlePlatform has no tests at the moment. Is that correct? |
@SenseException looking good, merging. True, unfortunately we do not have a test class for the Drizzle platform yet :( So I'm fine with skipping it for the moment. Thanks! |
[DBAL-1090] Changing string to fixed string is not recognized in PostgreSQL Platform
The following change of an entity using PostgreSQL is not recognized by Doctrine DBAL:
from
to
A schema-update should change the column from
character varying(2)
tocharacter(2)
but instead acts like no changes were made on the column.With this PR, I've extended the
PostgreSqlPlatform
to detect changes of the fixed option of a column.