Removed non-phpdoc @internal tags #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1075 We use Jira to track the state of pull requests and the versions they got |
Ocramius
added a commit
that referenced
this pull request
Dec 16, 2014
Removed non-phpdoc @internal tags
|
@acrobat thanks! |
| @@ -969,8 +967,6 @@ public function query() | |||
| * @return integer The number of affected rows. | |||
| * | |||
| * @throws \Doctrine\DBAL\DBALException | |||
| * | |||
| * @internal PERF: Directly prepares a driver statement, not a wrapper. | |||
There was a problem hiding this comment.
should the comment be removed though ?
This was referenced Dec 6, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed 2 @internal phpdoc tags as they were about old internal api usage and these methods are public api as @beberlei & @Ocramius confirmed on irc #doctrine