Take care about mariadb platform

[nlegoff]

Hi,
After upgrading to DBAL 2.5, I got an issue where I could not rename index while migrating because of MariaDB versioning which outputs 10.0.15-MariaDB-1~wheezy as server version.

Because 10.x > 5.7 it loads new features from mysql 5.7 which are not available in mariadb ..

[doctrinebot]

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-1073

We use Jira to track the state of pull requests and the versions they got
included in.

[deeky666]

looks sane to me. Please add some test data here and I'll merge.

[Ocramius]

Should we have a different platform for mariadb? The entire mariadb-mysql-yaddayadda-galeracluster-xtradb stuff is going to get out of hand.

[nlegoff]

@deeky666 added some test cases.

[stof]

@Ocramius having a specific platform which would be the same than MySQLPlatform is not worth the maintenance IMO. And having a MariaDBDriver forcing the usage of this platform would make things more complex.

IMO, detecting MariaDB versions is the best approach for our users, as this keeps MariaDB as a drop-in replacement (but it is a drop-in replacement for 5.6 in its version 10.0)

[Ocramius]

The point is that MariaDB is becoming less of a drop-in replacement as time passes (like with any forked software)

[deeky666]

@stof @Ocramius I tend to agree with you both. I think this solution here is acceptable for now considering, that the current DBAL MySQL platforms are not differenciated enough to even reflect all of MySQL's version specific semantics (especially reserved keywords which even tend to change in patch versions regularly).
Introducing distinct platforms for MariaDB would also require to add a distinct schema manager, tests etc. This is a lot of effort for nearly no benefit in the current state. Also I don't remember we mention anywhere that MariaDB is officially supported by DBAL. So we should reconsider differenciating both vendors in 3.0 but I doubt it makes a lot of sense in 2.x.

[Ocramius]

I doubt it makes a lot of sense in 2.x.

👍

[deeky666]

@nlegoff thx!