Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DriverException.php: Adding SQL to error message #6814

Closed
wants to merge 1 commit into from
Closed

Update DriverException.php: Adding SQL to error message #6814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Exception/DriverException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
private readonly ?Query $query,
) {
if ($query !== null) {
$message = 'An exception occurred while executing a query: ' . $driverException->getMessage();
$message = 'An exception occurred while executing a query: ' . $driverException->getMessage() . ' | SQL: ' . $query->getSQL() . ' | Params: ' . $query->getParams();

Check failure on line 27 in src/Exception/DriverException.php

View workflow job for this annotation

GitHub Actions / Static Analysis / PHPStan (PHP: 8.4) 

Binary operation "." between non-falsy-string and array<mixed> results in an error.

Check warning on line 27 in src/Exception/DriverException.php

View workflow job for this annotation

GitHub Actions / Coding Standards / Coding Standards (PHP: 8.4) 

Line exceeds 120 characters; contains 176 characters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The query and definitely the parameters may contain sensitive information.

} else {
$message = 'An exception occurred in the driver: ' . $driverException->getMessage();
}
Expand Down
Loading