Auto-quote introspected PostgreSQL identifiers #6756
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schema managers for the platforms that respect SQL-92 with regard to identifier case sensitivity should introspect the identifiers with characters in lower case (or, for PostgreSQL, in upper case) as quoted. Otherwise, their actual case may get lost in translation.
Note
All identifiers should be always introspected as quoted but prior to #6589 (DBAL 5.0) it would be a BC break.
Currently, the Oracle schema manager does it via
getQuotedIdentifierName()
. The PostgreSQL one usesquote_ident()
in schema introspection queries, but inconsistently, which leads to the bugs:Users
andusers
), all columns, indexes and foreign keys will be attributed to the lower-case one. This is covered bytestDropWithAutoincrement()
. If an upper-case table is introspected as unquoted, it will try to drop it without quoting the name and fail (because the database will automatically lower-case the unquoted name).