Convert proxy factory auto generate mode to integer #815
Conversation
There was a problem hiding this comment.
@dragosprotung some small nitpickings and CS fixes to be done (I'm sending a PR that will add PHPCS to help to detect and use phpcbf to fix them).
And please use master as the destination branch, we'll handle the necessary backporting 😄
Thanks for you contribution 👍
| * | ||
| * @return self | ||
| */ | ||
| public static function invalidAutoGenerateMode($value) |
There was a problem hiding this comment.
Please add the return type declation
| [$proxyGenerator, $metadataFactory, $autoGenerate] | ||
| ); | ||
|
|
||
| $this->assertAttributeSame($expected, 'autoGenerate', $proxyFactory); |
| * @param mixed $autoGenerate | ||
| * @param int $expected | ||
| */ | ||
| public function testNoExceptionIsThrownForValidIntegerAutoGenerateValues($autoGenerate, $expected) |
There was a problem hiding this comment.
Please add the type declaration on $expected and : void as return type
|
I changed the commit base to master and resolved in GitHub UI the conflict and this made a bit of a mess. Don't know how to have a cleaner PR. Shall I close this one and submit a new one ? |
|
@dragosprotung we usually use |
|
Usually I use rebase, but not this time. |
No description provided.