feat(slider clickable) : Added slider as clickable #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ssatz Thank you for this great contribution! At first glance this looks good to me, but I will check thoroughly tonight. Also, the 'initial' property is not important to these changes. |
|
@ssatz update: I had to work late so I did not get to look at this yet. I'll have plenty of time this weekend though. |
|
@dockleryxk 👍 Also need to add router module to support routerlink. |
|
@ssatz I have not forgotten about this! When I tried to merge a different PR it took up too much time to merge this. I have reverted that and will get to this asap. |
|
@dockleryxk : 👍 pls check #11 which will be easy for you to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dockleryxk : Thanks for the wonderful package.
I have added slider as clickable. Please review it and let me know if you are okay.
I have changed the
<div>to<a>tag for SEO also am not sure about the property initial