network: multiple nets with --network #19566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrects a false statement that you can't connect to multiple networks with the `--network` flag. Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
github-actions
bot
added
the
area/networking
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
craig-osterhout
approved these changes
Mar 5, 2024
akerouanton
reviewed
Mar 5, 2024
| @@ -139,8 +139,9 @@ A container receives an IP address out of the IP subnet of the network. | |||
| The Docker daemon performs dynamic subnetting and IP address allocation for containers. | |||
| Each network also has a default subnet mask and gateway. | |||
|
|
|||
| When a container starts, it can only attach to a single network, using the `--network` flag. | |||
| You can connect a running container to additional networks using the `docker network connect` command. | |||
| You can connect a running container to multiple networks, | |||
There was a problem hiding this comment.
I think it'd be valuable to detail how the advanced --network format can be used to attach to multiple networks. I think the doc doesn't mention that right now. Here's the relevant PRs:
- Add missing opts to --network advanced syntax cli#4419
- [carry 317] Cli change to pass driver specific options to docker run cli#1767
I think it might worth also mentioning how the CLI interprets top-level flags when multiple networks are specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Karlsson 35727626+dvdksn@users.noreply.github.com
Description
Corrects a false statement that you can't connect to multiple networks
with the
--networkflag.Related issues or tickets
Closes #19533