-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint gha job and remove travis #231
Conversation
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
==========================================
+ Coverage 51.13% 55.25% +4.11%
==========================================
Files 9 9
Lines 659 666 +7
==========================================
+ Hits 337 368 +31
+ Misses 286 255 -31
- Partials 36 43 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ef4727f
to
b59d72c
Compare
51dae24
to
2eb25bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two comments, but otherwise looks good, thanks!
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
use golangci-lint and adds ci validation
this was the last piece in travis so we can remove travis config. I also found the
pass
tests were not covered because gpg key and pass was not initialized. Now pass tests run both on ci and in the Dockerfile.