Enabled ppc64le as an architecture #172
Closed
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made changes to use ppc64le under "arch" instead of as an "os" arch: - ppc64le Signed-off-by: Vrushali Inamdar <vrushali.inamdar@ibm.com>
Enabled ppc64le as an architecture Signed-off-by: Vrushali Inamdar <vrushali.inamdar@ibm.com>
|
Hi Team, Could you please comment on this request? |
|
Hi @vrushaliinamdar -- this is a dup of #144. Have you considered submitting a PR for this update yourself? We know that this project does build easily on ppc64le. |
|
I don't think this change currently does what it was intended to do, because now it only runs on ppc64le, so looks like more changes are needed;
|
|
@thaJeztah ok to close this? you're right -- this PR does only build for power, whereas before it already built power binaries, but they aren't being published. |
|
We enabled cross-builds for s390x and ppc64le in #227 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled ppc64le under "arch" instead of specifying under "os"
arch:
- ppc64le