Release containerd 1.2.6 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
docker/engine 18.09 counterpart for this; docker-archive/engine#194 |
seemethere
previously approved these changes
Apr 9, 2019
|
rebased to get rid of the commit from #89 |
seemethere
previously approved these changes
Apr 9, 2019
|
Hmm; think I've copy-pasted something; Looking now |
seemethere
reviewed
Apr 9, 2019
debian/changelog
Outdated
| @@ -1,3 +1,11 @@ | |||
| containerd.io (v1.2.6-1) release; urgency=medium | |||
There was a problem hiding this comment.
The leading v will cause the build to error out
There was a problem hiding this comment.
Yes, I noticed; apparently I did it wrong initially last time, because my shell autocompleted including the v 😂
I can look at a check in the release scripts, so that they fail when trying to use a version with a leading v
- containerd 1.2.6 release - update runc to 029124da7af7360afa781a0234d1b083550f797c - build with Go 1.11.8 containerd changelog: https://github.com/containerd/containerd/releases/tag/v1.2.6 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Apr 9, 2019
| @@ -167,7 +172,7 @@ install -p -m 644 man/*.5 $RPM_BUILD_ROOT/%{_mandir}/man5 | |||
| - containerd 1.2.1 release | |||
| - update runc to 96ec2177ae841256168fcf76954f7177af9446eb | |||
|
|
|||
| * Tue Nov 27 2018 Sebastiaan van Stijn <thajeztah@docker.com> - v1.2.1-2.0.rc.0.1 | |||
| * Tue Nov 27 2018 Sebastiaan van Stijn <thajeztah@docker.com> - 1.2.1-2.0.rc.0.1 | |||
There was a problem hiding this comment.
fixed it here as well 😇
|
Failed on; restarted CI |
|
Sounds like fedora repositories near a new release 😆 |
seemethere
approved these changes
Apr 9, 2019
|
Boooh! Guess I need to restart everything again 😞 |
|
I trust that this works so I'm going to go ahead and just merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #89 (commit included in this PR)
containerd changelog: https://github.com/containerd/containerd/releases/tag/v1.2.6