Test commandName subcommand order #12535
Open
+52
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @maxproske |
|
No worries, let me know if the original sorting is desired, and I'll update the comment/test accordingly. |
ndeloof
reviewed
Feb 9, 2025
cmd/cmdtrace/cmd_span.go
Outdated
| @@ -130,7 +129,9 @@ func commandName(cmd *cobra.Command) []string { | |||
| } | |||
| name = append(name, c.Name()) | |||
| } | |||
| sort.Sort(sort.Reverse(sort.StringSlice(name))) | |||
| for i, j := 0, len(name)-1; i < j; i, j = i+1, j-1 { | |||
There was a problem hiding this comment.
can use slices.Reverse - which basically does the same, but will make the intent obvious
|
I indeed need to check the impact on usage metrics |
Signed-off-by: Max Proske <max@mproske.com>
maxproske
force-pushed
the
feature/span-cli-order
branch
from
a61163b to
c52c3b3
Compare
maxproske
changed the title
|
Reverted to the original sorting, and updated the tests/comment to match intended behaviour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Previously, when the root CLI span
cli/<cmd>was named, the subcommand path was returned in reverse alphabetical order instead of CLI order, contradicting the comment above the function.edit: Reverted to the original sorting and updated test and function comment to clarify intended behaviour.
Before:
After:
(not mandatory) A picture of a cute animal, if possible in relation to what you did