Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Replace deprecated command with environment file #10242

Merged
merged 1 commit into from
Feb 4, 2023
Merged

ci: Replace deprecated command with environment file #10242

merged 1 commit into from
Feb 4, 2023

Conversation

jongwooo
Copy link
Contributor

@jongwooo jongwooo commented Feb 4, 2023

Signed-off-by: jongwooo jongwooo.han@gmail.com

Description

Resolve #10241

Update workflows to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow files that use set-output command through the following command:

$ find .github/workflows -name '*.yml' | xargs egrep '\bset-output\b'

AS-IS

run: |
  echo ::set-output name=matrix::$(docker buildx bake binary-cross --print | jq -cr '.target."binary-cross".platforms')

TO-BE

run: |
  echo matrix=$(docker buildx bake binary-cross --print | jq -cr '.target."binary-cross".platforms') >> $GITHUB_OUTPUT

Signed-off-by: jongwooo <jongwooo.han@gmail.com>
@codecov
Copy link

codecov bot commented Feb 4, 2023

Codecov Report

Base: 73.89% // Head: 73.89% // No change to project coverage 👍

Coverage data is based on head (3077234) compared to base (23585b9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2   #10242   +/-   ##
=======================================
  Coverage   73.89%   73.89%           
=======================================
  Files           2        2           
  Lines         272      272           
=======================================
  Hits          201      201           
  Misses         60       60           
  Partials       11       11           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 🙏

@glours glours merged commit b3ec110 into docker:v2 Feb 4, 2023
@jongwooo jongwooo deleted the ci/replace-deprecated-command-with-environment-file branch February 4, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file
2 participants