Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry run pause support #10217

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Dry run pause support #10217

merged 1 commit into from
Jan 31, 2023

Conversation

glours
Copy link
Contributor

@glours glours commented Jan 30, 2023

What I did
Add support for of dry-run for the pause and unpause command

Need #10210 to be merged first

Related issue
https://docker.atlassian.net/browse/ENV-81

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours glours force-pushed the dry-run-pause-support branch from fe375c1 to 6754c6b Compare January 30, 2023 09:36
@glours glours marked this pull request as ready for review January 30, 2023 09:44
@glours glours self-assigned this Jan 30, 2023
@glours glours requested review from a team, nicksieger, ndeloof, StefanScherer, ulyssessouza, milas and laurazard and removed request for a team January 30, 2023 09:44
@glours glours enabled auto-merge January 30, 2023 09:44
@glours glours disabled auto-merge January 30, 2023 09:44
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 73.89% // Head: 73.89% // No change to project coverage 👍

Coverage data is based on head (6754c6b) compared to base (a93f09e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2   #10217   +/-   ##
=======================================
  Coverage   73.89%   73.89%           
=======================================
  Files           2        2           
  Lines         272      272           
=======================================
  Hits          201      201           
  Misses         60       60           
  Partials       11       11           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@glours glours merged commit f24d345 into docker:v2 Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants