Fix flag description for --host-add #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--host-add` flag adds a new `host:ip` mapping. Even though adding an entry is idempotent (adding the same mapping multiple times does not update the service's definition), it does not _update_ an existing mapping with a new IP-address (multiple IP-addresses can be defined for a host). This patch removes the "or update" part from the flag's description. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
@@ Coverage Diff @@
## master #648 +/- ##
=========================================
- Coverage 49.8% 49.8% -0.01%
=========================================
Files 210 210
Lines 17292 17292
=========================================
- Hits 8613 8612 -1
- Misses 8253 8254 +1
Partials 426 426 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--host-addflag adds a newhost:ipmapping. Even though adding an entry is idempotent (adding the same mapping multiple times does not update the service's definition), it does not update an existing mapping with a new IP-address (multiple IP-addresses can be defined for a host).This patch removes the "or update" part from the flag's description.
relates to moby/moby#35325
There's possibly some other flags that fall in the same category, but I kept those out for now (can do a follow up)
ping @vdemeester @dnephin PTAL