[Compose] Cast values to expected type after interpolating values #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
dnephin
force-pushed
the
compose-cast-after-interpolate
branch
2 times, most recently
from
3dd96e1 to
ea107b5
Compare
dnephin
commented
Oct 4, 2017
| @@ -80,7 +76,7 @@ func recursiveInterpolate( | |||
| case []interface{}: | |||
| out := make([]interface{}, len(value)) | |||
| for i, elem := range value { | |||
| interpolatedElem, err := recursiveInterpolate(elem, mapping) | |||
| interpolatedElem, err := recursiveInterpolate(elem, path, opts) | |||
There was a problem hiding this comment.
I think maybe lists should have a [] item in the path to differentiate a path to a scalar or a path to an item in the list.
dnephin
force-pushed
the
compose-cast-after-interpolate
branch
from
ea107b5 to
eff766d
Compare
Signed-off-by: Daniel Nephin <dnephin@docker.com>
dnephin
force-pushed
the
compose-cast-after-interpolate
branch
from
eff766d to
af8f563
Compare
|
Would be amazing to get this soon :) |
seriousben
approved these changes
Oct 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #229
Required a change to the order of operations to handle interpolation before schema validation. This should be safe because interpolation should not require any specific structure.
cc @shin-
@vdemeester sorry in advance for conflicts with #569 if this merges first