Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vndr to a6e196d8b4b0cbbdc29aebdb20c59ac6926bb384 #571

Merged
merged 1 commit into from
Sep 29, 2017

Conversation

thaJeztah
Copy link
Member

Includes a fix to cleanup unused vendor-directories;

"cleanup packages which does not contain go files" LK4D4/vndr#57, reported by @dnephin in LK4D4/vndr#55

ping @dnephin @vdemeester

Includes a fix to cleanup unused vendor-directories

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-io
Copy link

Codecov Report

Merging #571 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
- Coverage   49.41%   49.41%   -0.01%     
==========================================
  Files         208      208              
  Lines       17164    17164              
==========================================
- Hits         8482     8481       -1     
- Misses       8249     8250       +1     
  Partials      433      433

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐮

Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm surprised it didn't remove more files

@thaJeztah
Copy link
Member Author

Yes, apparently not that many empty directories

@thaJeztah thaJeztah merged commit 107f6c6 into docker:master Sep 29, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.10.0 milestone Sep 29, 2017
@thaJeztah thaJeztah deleted the bump-vndr branch September 29, 2017 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants