Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add --pids-limit flag to docker update #181

Closed
wants to merge 2 commits into from

Conversation

darkowlzz
Copy link
Contributor

@darkowlzz darkowlzz commented Jun 12, 2017

- What I did

Added pids-limit flag to docker update command. Also added completion for bash and zsh.

- Description for the changelog

Add --pids-limit flag to docker update

Refer: moby/moby#32519

@codecov-io
Copy link

codecov-io commented Jun 12, 2017

Codecov Report

Merging #181 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
- Coverage   45.67%   45.66%   -0.02%     
==========================================
  Files         171      171              
  Lines       11513    11516       +3     
==========================================
  Hits         5259     5259              
- Misses       5947     5950       +3     
  Partials      307      307

@dnephin
Copy link
Contributor

dnephin commented Jun 12, 2017

We should add this to the Compose file as well.

  • cli/compose/schema/
  • cli/compose/types/
  • cli/compose/convert/

@darkowlzz
Copy link
Contributor Author

Adding PidsLimit to compose file requires swarm Resources to have PidsLimit. Creating another PR in moby/moby for the same.

@dnephin
Copy link
Contributor

dnephin commented Jun 14, 2017

Oops, my mistake. I thought this was being added to docker service update. This is fine without the Compose changes. You can remove them from this PR.

@thaJeztah
Copy link
Member

@darkowlzz sorry for all the hassle; it looks like you forgot to move the documentation changes to this repository.

We should wait for the changes in moby/moby upstream to be merged first

Signed-off-by: Sunny Gogoi <indiasuny000@gmail.com>
@darkowlzz
Copy link
Contributor Author

Removed the commit related to Compose changes and updated commandline/update docs.

Signed-off-by: Sunny Gogoi <indiasuny000@gmail.com>
@dnephin
Copy link
Contributor

dnephin commented Feb 16, 2018

Looks like the moby/moby support hasn't merged yet

@thaJeztah thaJeztah changed the title Add --pids-limit flag to docker update [WIP] Add --pids-limit flag to docker update May 19, 2018
@thaJeztah
Copy link
Member

carrying in #1765 so that it may still make the cut-off for 19.03 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants