dial-stdio: fix goroutine leakage #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix docker#1736 Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Codecov Report
@@ Coverage Diff @@
## master #1772 +/- ##
=======================================
Coverage 56.26% 56.26%
=======================================
Files 308 308
Lines 21293 21293
=======================================
Hits 11980 11980
Misses 8439 8439
Partials 874 874 |
|
@ijc @silvin-lubecki PTAL we likely want to cherry-pick this one? |
|
ping @tiborvass @tonistiigi PTAL |
tiborvass
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp
- What I did
Fix #1736
- How I did it
Use buffered channel as suggested by @andrey-ko (thanks)
- How to verify it
#1736
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
🐧