Fix yamldocs outputing [flags] in usage output
#1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A similar change was made in the CLI itself, but is not inherited by the code that generates the YAML docs. Before this patch is applied; ``` usage: docker container exec [OPTIONS] CONTAINER COMMAND [ARG...] [flags] ``` With this patch applied: ``` usage: docker container exec [OPTIONS] CONTAINER COMMAND [ARG...] ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
ping @tiborvass @vdemeester PTAL |
This was referenced Nov 29, 2018
Codecov Report
@@ Coverage Diff @@
## master #1539 +/- ##
=======================================
Coverage 55.22% 55.22%
=======================================
Files 289 289
Lines 19389 19389
=======================================
Hits 10708 10708
Misses 7984 7984
Partials 697 697 |
seemethere
approved these changes
Nov 29, 2018
tonistiigi
approved these changes
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A similar change was made in the CLI itself in #1069, but is not inherited by the code that generates the YAML docs.
Before this patch is applied;
With this patch applied:
- How to verify it
run
make -f docker.Makefile yamldocsand check the generated YAML files indocs/yaml/gen/