Allow removing an App when referenced by id in unambiguous cases

Signed-off-by: Jean-Christophe Sirot <jean-christophe.sirot@docker.com>
docker · Nov 13, 2019 · e436fbe · e436fbe
1 parent 61e61a8
commit e436fbe
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/internal/store/bundle.go b/internal/store/bundle.go
@@ -112,6 +112,14 @@ func (b *bundleStore) List() ([]reference.Reference, error) {
 
 // Remove removes a bundle from the bundle store.
 func (b *bundleStore) Remove(ref reference.Reference) error {
+	if id, ok := ref.(ID); ok {
+		if len(b.refsMap[id]) == 0 {
+			return fmt.Errorf("no such image %q", reference.FamiliarString(ref))
+		} else if len(b.refsMap[id]) > 1 {
+			return fmt.Errorf("unable to delete %s - App is referenced in multiple repositories", reference.FamiliarString(ref))
+		}
+		ref = b.refsMap[id][0]
+	}
 	path, err := b.storePath(ref)
 	if err != nil {
 		return err