Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace HTCondorUtils.quote/unquote with classad.(un)quote #8332

Closed
Tracked by #8337
belforte opened this issue Apr 11, 2024 · 2 comments
Closed
Tracked by #8337

replace HTCondorUtils.quote/unquote with classad.(un)quote #8332

belforte opened this issue Apr 11, 2024 · 2 comments
Assignees
@belforte
Labels
Area: Code Cleanup Area: HTCondor Priority: High Status: In Progress

Comments

@belforte
Copy link
Member

there's non reason anymore to have our implementation, HTCondor classad library fully supports all classAd manipulations
@belforte belforte self-assigned this Apr 11, 2024
@belforte
Copy link
Member Author

do this as part of porting to new HTCondor bindings #8272 , since this is the time we put our hands in this part of the code and if we do not do it know, we may never do

@belforte
Copy link
Member Author

belforte commented Apr 11, 2024 •
edited
Loading

There's more cleanup that can be done in classAd manipulation area.
I am putting some comments in DagmanSubmitter as a start
That may make all this part more readable.

After a bit of reading, that will come via #8336

@belforte belforte mentioned this issue Apr 15, 2024
Closed
13 tasks
belforte added a commit to belforte/CRABServer that referenced this issue Apr 16, 2024
@belforte
use classad.quote, not HTCondorUtils. Fix dmwm#8332
a830058
@belforte belforte mentioned this issue Apr 16, 2024
Closed
3 tasks
belforte added a commit to belforte/CRABServer that referenced this issue Apr 18, 2024
@belforte
use classad.quote, not HTCondorUtils. Fix dmwm#8332
2cbd331
belforte added a commit to belforte/CRABServer that referenced this issue Apr 18, 2024
@belforte
use classad.quote, not HTCondorUtils. Fix dmwm#8332
dcf2edd
belforte added a commit to belforte/CRABServer that referenced this issue Apr 19, 2024
@belforte
use classad.quote, not HTCondorUtils. Fix dmwm#8332
8ea9a3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@belforte belforte

Labels
Area: Code Cleanup Area: HTCondor Priority: High Status: In Progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@belforte