Allow to pass units to diff method #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #445 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 708 746 +38
Branches 76 79 +3
=========================================
+ Hits 708 746 +38
Continue to review full report at Codecov.
|
sorry but i don't know how to fix such error |
dmtrKovalenko
approved these changes
Aug 27, 2020
This was referenced Mar 15, 2021
smmoosavi
reviewed
Mar 17, 2021
Comment on lines
+4
to
+12
| import differenceInYears from "date-fns/differenceInYears"; | ||
| import differenceInQuarters from "date-fns/differenceInQuarters"; | ||
| import differenceInMonths from "date-fns/differenceInMonths"; | ||
| import differenceInWeeks from "date-fns/differenceInWeeks"; | ||
| import differenceInDays from "date-fns/differenceInDays"; | ||
| import differenceInHours from "date-fns/differenceInHours"; | ||
| import differenceInMinutes from "date-fns/differenceInMinutes"; | ||
| import differenceInSeconds from "date-fns/differenceInSeconds"; | ||
| import differenceInMilliseconds from "date-fns/differenceInMilliseconds"; |
There was a problem hiding this comment.
these function should be imported from date-fns-jalali
I just fixed theme in #550
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.