-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update golang.org/x/tools to v0.30.0 #106
Conversation
Drop enumer package from flake. Future work: - Remove /x/tools dependency override once dmarkham/enumer#106 merges.
@gabe565 can we merge this PR? |
iirc we need to bump the version but then I or @dmarkham could merge. I'd like his input because I don't have a ton of experience contributing to enumer. I'll reach out to him to take a look if he doesn't see my ping. |
A tagged release would be nice since most users will eventually need exactly this fix for their projects |
Yeah, I can confirm the PR fixes these errors with Go v1.24. It's ready to merge whenever @samiam2013 and @dmarkham are ready! |
@samiam2013 are you able to have a look at this? |
I can confirm that the tests are also failing on go 1.24 and that this PR fixes it. The action which includes the test passed before using 1.21 and again just now with 1.22. I need to switch computers to reproduce the original problem though, just to confirm we're also seeing or going to see it and this fixes that as well, not just the test that broke. |
I can also confirm now that this is reproducible and @gabe565's pull request fixes the problem as stated. I think this is ready to merge and tag. |
got the verbal go ahead from @dmarkham, merging & tagging now |
On Go v1.24, enumer fails with import errors like
To fix this,
golang.org/x/tools
must be updated to v0.25.0 or greater, so this PR updatesgolang.org/x/tools
to v0.30.0.Note that this also increases the minimum supported Go version to v1.22.
Fixes #105