Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang.org/x/tools to v0.30.0 #106

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Conversation

gabe565
Copy link
Contributor

@gabe565 gabe565 commented Feb 12, 2025

On Go v1.24, enumer fails with import errors like

enumer: internal error: package "os" without types was imported from "..."

To fix this, golang.org/x/tools must be updated to v0.25.0 or greater, so this PR updates golang.org/x/tools to v0.30.0.

Note that this also increases the minimum supported Go version to v1.22.

Fixes #105

@gabe565 gabe565 changed the title Upgrade golang.org/x/tools to v0.30.0 Update golang.org/x/tools to v0.30.0 Feb 12, 2025
bdd added a commit to bdd/runitor that referenced this pull request Feb 17, 2025
Drop enumer package from flake.

Future work:
- Remove /x/tools dependency override once
  dmarkham/enumer#106 merges.
@tedkornish
Copy link

@gabe565 can we merge this PR?

@samiam2013
Copy link
Collaborator

iirc we need to bump the version but then I or @dmarkham could merge. I'd like his input because I don't have a ton of experience contributing to enumer. I'll reach out to him to take a look if he doesn't see my ping.

@dsseng
Copy link

dsseng commented Feb 17, 2025

iirc we need to bump the version but then I or @dmarkham could merge. I'd like his input because I don't have a ton of experience contributing to enumer. I'll reach out to him to take a look if he doesn't see my ping.

A tagged release would be nice since most users will eventually need exactly this fix for their projects

@gabe565
Copy link
Contributor Author

gabe565 commented Feb 17, 2025

Yeah, I can confirm the PR fixes these errors with Go v1.24. It's ready to merge whenever @samiam2013 and @dmarkham are ready!

@dmarkham
Copy link
Owner

@samiam2013 are you able to have a look at this?

@samiam2013
Copy link
Collaborator

I can confirm that the tests are also failing on go 1.24 and that this PR fixes it. The action which includes the test passed before using 1.21 and again just now with 1.22. I need to switch computers to reproduce the original problem though, just to confirm we're also seeing or going to see it and this fixes that as well, not just the test that broke.

@samiam2013
Copy link
Collaborator

I can also confirm now that this is reproducible and @gabe565's pull request fixes the problem as stated. I think this is ready to merge and tag.

@samiam2013
Copy link
Collaborator

got the verbal go ahead from @dmarkham, merging & tagging now

@samiam2013 samiam2013 merged commit 750eb57 into dmarkham:master Feb 18, 2025
1 check passed
@gabe565 gabe565 deleted the fix-go-1.24 branch February 18, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure on Go v1.24
6 participants