Fix auto-signing new input when using accountingSign option
#399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hi, first I want to thank you for contributing and reporting the issue. |
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
==========================================
- Coverage 93.45% 93.04% -0.41%
==========================================
Files 7 7
Lines 672 676 +4
Branches 189 190 +1
==========================================
+ Hits 628 629 +1
- Misses 44 47 +3
|
dm4t2
changed the title
accountingSign option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I have spotted an issue relating to the usage of the accounting sign. It is a case when you focus a field using the TAB key. Whenever you TAB into an input field (whole text gets selected), whatever you is being typed in there will first discard the last (closing) parenthesis and as the typing continues the caret uncontrollably shifts its location. I would like you in this respect to consider this MR as it resolves the issue....or any other solution leading to the resolution for the issue.