Fix Main Release and other PR workflows #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelLangbein
approved these changes
Mar 10, 2022
| const allPackageDeps = []; | ||
| // Resolve package path and then read package.json with FS because some packages do not list ./package.json on there exports so if we require the package.json an error occurres. | ||
| // Package subpath './package.json' is not defined by "exports" | ||
| const resPackagePath = browserifyResolve(packagePath); |
There was a problem hiding this comment.
Thanks for the switch to browserifyResove!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The CI for all PR's not following the release format is failing, and merging a PR with failed checks is not acceptable.
What is the new behavior?
The workflow for Main Release is skipped now for all branches not named
release-...Fix: resolve not exported package in the build task bcda5cc
Update some dependencies from dependabot and scripts dbf80bf
Fix: styles for vertical nav right icon 55b32a4
closes Build(deps): bump three from 0.132.2 to 0.137.0 #111
Does this PR introduce a breaking change?