GitHub's API + UI don't return 0.9.20 anymore #1579
Conversation
|
Thanks for your pull request, @wilzbach! |
wilzbach
force-pushed
the
fix-gh-api-bug
branch
from
92f0b7c to
2045a95
Compare
| echo 1 | $DUB remove dub | tr -d '\n' | grep --ignore-case 'select.*0\.9\.20.*0\.9\.21.*' | ||
| if [ -d $HOME/.dub/packages/dub-0.9.20/dub ]; then | ||
| die $LINENO 'Failed to remove dub-0.9.20' | ||
| echo 1 | $DUB remove dub | tr -d '\n' | grep --ignore-case 'select.*1\.9\.0.*1\.10\.0.*' |
There was a problem hiding this comment.
Hmm this doesn't seem to work with DMD 2.077:
Select version of 'dub' to remove from location 'user':1) 1.1.02) 1.9.03) 1.10.04) all versions> Removing dub in /home/travis/.dub/packages/dub-1.1.0/dub/Removed package: 'dub'Removed dub, version 1.1.0.
[ERROR] /home/travis/build/dlang/dub/test/interactive-remove.sh:12 Failed to remove dub-1.9.0
There was a problem hiding this comment.
Ouch this is probably due to COVERAGE mode and dub's testsuite being rerun multiple times.
|
Ok so this is passing Travis now |
|
As no one seems to be having an opinion and the testsuite is broken, I will merge this tomorrow baring no objections until then. |
|
Well it's there now, was this just a temporary github issue? |
|
Maybe it was removed from the dub registry due to having an invalid package recipe. It's definitely no longer in the db. Or the registry got confused by the github hickup. It's a bit confusing that https://buildkite.com/dlang/ci/builds/511#4c02ce8c-f1a7-4899-bc6d-bcf91ba4d9ee passed and https://buildkite.com/dlang/phobos/builds/582#3ddd20c7-ec9f-4455-838e-061bb4d3a14b/106-716 subsequently failed. The culprit seems to be that no distinction is made between building dub (as in dub the tool) where we want to use the dev version, and dub (as in dub the project with testsuite) where we want to use the latest stable release. |
GitHub's API + UI don't return 0.9.20 anymore
The 0.9.20 tag is still there, see e.g.
But not on the web UI nor API, e.g.
https://github.com/dlang/dub/tags?after=v0.9.22-beta.2
This is the pragmatic solution to fixing the test suite.