Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: frontend ci tests #617

Merged
merged 9 commits into from
Jun 15, 2022
Merged

fix: frontend ci tests #617

merged 9 commits into from
Jun 15, 2022

Conversation

vinitkumar
Copy link
Member

@vinitkumar vinitkumar commented Jun 14, 2022

Fix the issue with frontend test crashing because "graceful-fs": "^4.2.4" was added in package-lock.json.

This is fixed by remove ^ from the version and generating a package-lock.json makes it work.

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #617 (f03ca94) into master (31cb918) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #617   +/-   ##
=======================================
  Coverage   74.91%   74.91%           
=======================================
  Files          20       20           
  Lines         905      905           
  Branches      128      128           
=======================================
  Hits          678      678           
  Misses        199      199           
  Partials       28       28           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31cb918...f03ca94. Read the comment docs.

@vinitkumar vinitkumar requested review from marksweb and fsbraun June 14, 2022 20:48
Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much, @vinitkumar !

Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vinitkumar!

@marksweb marksweb merged commit 325432d into master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants