-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: frontend ci tests #617
Conversation
Codecov Report
@@ Coverage Diff @@
## master #617 +/- ##
=======================================
Coverage 74.91% 74.91%
=======================================
Files 20 20
Lines 905 905
Branches 128 128
=======================================
Hits 678 678
Misses 199 199
Partials 28 28 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much, @vinitkumar !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vinitkumar!
Fix the issue with frontend test crashing because
"graceful-fs": "^4.2.4"
was added in package-lock.json.This is fixed by remove ^ from the version and generating a package-lock.json makes it work.