Use results from SBI index instead of ignoring them #124
+20
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We were querying the SBI index, throwing those results away, and then split-guessing. * Now the sbi results are used if they are available. * Fixes #123
|
@heuermh Could you take a look at this one when you get a chance? It's a pretty nasty bug. |
heuermh
approved these changes
Dec 12, 2019
|
@lbergelson Thanks for the ping, sorry I left this sitting so long. Do you want to squash commits and rebase, or shall I do it with the GitHub Squash and Merge button? |
|
No worries, I just wanted to be sure you had noticed it. Thanks for taking a look. |
|
Thank you, @lbergelson @wangdy12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wangdy12 I believe this fixes the problem. I'm shocked we never noticed that before, but I guess I always run with verbosity higher than debug.