Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Cleanup & modernize #44

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Arkshine
Copy link
Contributor

@Arkshine Arkshine commented Mar 2, 2025

This PR fixes minor issues, modernizes, and does some cleanup.

  • Uses FormKit in the modal 1
    • Increases random ID length from 8 to 10 characters to avoid getting a popup saying ID is unsafe.
    • Groups the iframe-related checkboxes with a title for consistency, and simplifies the locale.
  • decorateCooked -> decorateCookedElement
  • Removes version from withPluginApi (TC is already pinned to 3.5.0.beta1-dev)
  • Renders the launch button with a glimmer component
    • The preview renders now the button (click is disabled). Before, there was nothing.
    • Fixes the username not filled when Jitsi loads. It replaces jitsiAPI.executeCommand by specifying the userInfo object.
    • Adds { once: true } param to jitsiAPI.addEventListener
    • Chat: fixed direct link when spaces are used by encoding room ID.
  • Updates lint configs
  • Adds system tests

Locales:

  • Added: modal.iframe_title
  • Modified: modal.desktop_iframe, modal.mobile_iframe

Footnotes

  1. Before/After
    chrome_vDG3WJF5Rm
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant