upgrade to RN0.42RC3

[nihgwu]

No description provided.

[SamSaffron]

Cool, will confirm this all works shortly 👍

Can you email me at sam.saffron<at>gmail.com so I can sort out paypal

[SamSaffron]

seem to be getting:

/Users/sam/Source/DiscourseMobile/node_modules/react-native/Libraries/ActionSheetIOS/RCTActionSheetManager.h:12:9: fatal error: 'React/RCTBridge.h' file not found
#import <React/RCTBridge.h>
        ^


** BUILD FAILED **


The following commands produced analyzer issues:
	Analyze RCTActionSheetManager.m
(1 command with analyzer issues)


The following build commands failed:
	CompileC /Users/sam/Source/DiscourseMobile/ios/build/Build/Intermediates/RCTSettings.build/Debug-iphonesimulator/RCTSettings.build/Objects-normal/x86_64/RCTSettingsManager.o RCTSettingsManager.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

When I run

react-native run-ios

[SamSaffron]

also totally failed when I try to compile in xcode :(

[nihgwu]

See the same errors when I download from zipped file, I'll try to figure out why, sorry for delay

[nihgwu]

Here is a trick, delete all the Libraries except React, build, then discard the change, now you can build successfully, but I still can't build from cli.

[nihgwu]

I need to sleep now, I think I've found the solution, will send a patch tomorrow, I'm from China 😄

[SamSaffron]

Thanks Neo !!!

…

On Wed, Feb 15, 2017 at 2:56 PM, Neo ***@***.***> wrote: I need to sleep now, I think I've found the solution, will send a patch tomorrow, I'm from China 😄 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAUXb6lXtKuj-F1XLVV9esU0m-M180eks5rc1hmgaJpZM4MCIC9> .

[nihgwu]

Hopefully I don't drop any configs

BTW:

1. Why your target is 9.0+
2. Orientation is supported by RN itself now, no need a 3rd-party library any more
3. use useNativeDriver everywhere when available, will make Animation much more smooth

[SamSaffron]

thanks, will merge soon, ping me via email!

[nihgwu]

can you build now? I'll wait until this be merged 😄

[SamSaffron]

Seems to be working find now ❤️ thanks so much

Why your target is 9.0+

I really did not want to support anything earlier, is there something else you would recommend here?

Orientation is supported by RN itself now, no need a 3rd-party library any more

Would love a PR to remove this dependency!

use useNativeDriver everywhere when available, will make Animation much more smooth

Would also love a PR for this.

[jjaffeux]

@nihgwu sorry to bother, do you know where the documentation is explaining Orientation please? Couldn't find anything.

[nihgwu]

@jjaffeux sorry it's my mistake, only Modal support Orientation

[jjaffeux]

@nihgwu ok ;) thanks