Skip to content

Commit

Permalink
chore(deps): lock file maintenance (#18)
Browse files Browse the repository at this point in the history
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Diogo Correia <me@diogotc.com>
  • Loading branch information
renovate[bot] and diogotcorreia authored Feb 19, 2025
1 parent 078d648 commit d488ab4
Show file tree
Hide file tree
Showing 5 changed files with 82 additions and 82 deletions.
37 changes: 18 additions & 19 deletions flake.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions flake.nix
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
spicetify-nix = {
url = "github:Gerg-L/spicetify-nix";
inputs.nixpkgs.follows = "nixpkgs-unstable";
# only used for non-flake setups, so we can get rid of it
inputs.flake-compat.follows = "";
};
lanzaboote = {
url = "github:nix-community/lanzaboote?ref=v0.4.2";
Expand Down
Original file line number Diff line number Diff line change
@@ -1,40 +1,43 @@
diff --git a/app/Console/AutoImports.php b/app/Console/AutoImports.php
index c45b296..33b8f00 100644
index 1ab510d..8e9438a 100644
--- a/app/Console/AutoImports.php
+++ b/app/Console/AutoImports.php
@@ -283,9 +283,6 @@ trait AutoImports
if (count($this->importErrors) > 0) {
return 1;
@@ -304,11 +304,6 @@ trait AutoImports

return ExitCode::GENERAL_ERROR->value;
}
- if (0 === count($messages) && 0 === count($warnings) && 0 === count($errors)) {
- return 73;
- app('log')->error(sprintf('Exit code is %s.', ExitCode::NOTHING_WAS_IMPORTED->name));
-
- return ExitCode::NOTHING_WAS_IMPORTED->value;
- }

return 0;
}
app('log')->error(sprintf('Exit code is %s.', ExitCode::SUCCESS->name));

diff --git a/app/Console/Commands/Import.php b/app/Console/Commands/Import.php
index bc5831b..dff21aa 100644
index b7eddbd..854cf54 100644
--- a/app/Console/Commands/Import.php
+++ b/app/Console/Commands/Import.php
@@ -157,9 +157,6 @@ final class Import extends Command
if (0 !== count($this->importErrors)) {
$exitCode = 1;
@@ -175,10 +175,6 @@ final class Import extends Command
$exitCode = ExitCode::GENERAL_ERROR->value;
app('log')->error(sprintf('Exit code is %s.', ExitCode::GENERAL_ERROR->name));
}
- if (0 === count($messages) && 0 === count($warnings) && 0 === count($errors)) {
- $exitCode = 73;
- $exitCode = ExitCode::NOTHING_WAS_IMPORTED->value;
- app('log')->error(sprintf('Exit code is %s.', ExitCode::NOTHING_WAS_IMPORTED->name));
- }

return $exitCode;
}
if ($exitCode === ExitCode::SUCCESS->value) {
app('log')->debug(sprintf('Exit code is %s.', ExitCode::SUCCESS->name));
}
diff --git a/app/Services/Nordigen/Conversion/RoutineManager.php b/app/Services/Nordigen/Conversion/RoutineManager.php
index 047df30..d259cf7 100644
index 4f8069f..d252b5d 100644
--- a/app/Services/Nordigen/Conversion/RoutineManager.php
+++ b/app/Services/Nordigen/Conversion/RoutineManager.php
@@ -329,7 +329,6 @@ class RoutineManager implements RoutineManagerInterface
@@ -328,7 +328,6 @@ class RoutineManager implements RoutineManagerInterface
if (0 === $total) {
app('log')->warning('Downloaded nothing, will return nothing.');
// add error to current error thing:
- $this->addError(0, 'No transactions were downloaded from GoCardless. You may be rate limited or something else went wrong.');
- $this->addError(0, '[a111]: No transactions were downloaded from GoCardless. You may be rate limited or something else went wrong.');
$this->mergeMessages(1);
$this->mergeWarnings(1);
$this->mergeErrors(1);
Original file line number Diff line number Diff line change
@@ -1,96 +1,96 @@
diff --git a/app/Console/AutoImports.php b/app/Console/AutoImports.php
index c45b296..01047d9 100644
index 8e9438a..77720ff 100644
--- a/app/Console/AutoImports.php
+++ b/app/Console/AutoImports.php
@@ -260,7 +260,8 @@ trait AutoImports
new ImportedTransactions(
@@ -279,7 +279,8 @@ trait AutoImports
array_merge($this->conversionMessages, $this->importMessages),
array_merge($this->conversionWarnings, $this->importWarnings),
- array_merge($this->conversionErrors, $this->importErrors)
+ array_merge($this->conversionErrors, $this->importErrors),
array_merge($this->conversionErrors, $this->importErrors),
- $this->conversionRateLimits
+ $this->conversionRateLimits,
+ $file
)
);

@@ -278,7 +279,7 @@ trait AutoImports
@@ -297,7 +298,7 @@ trait AutoImports
$messages = array_merge($this->importMessages, $this->conversionMessages);
$warnings = array_merge($this->importWarnings, $this->conversionWarnings);
$errors = array_merge($this->importErrors, $this->conversionErrors);
- event(new ImportedTransactions($messages, $warnings, $errors));
+ event(new ImportedTransactions($messages, $warnings, $errors, $file));
- event(new ImportedTransactions($messages, $warnings, $errors, $this->conversionRateLimits));
+ event(new ImportedTransactions($messages, $warnings, $errors, $this->conversionRateLimits, $file));

if (count($this->importErrors) > 0) {
return 1;
@@ -633,7 +634,8 @@ trait AutoImports
new ImportedTransactions(
if (count($this->importErrors) > 0 || count($this->conversionRateLimits) > 0) {
app('log')->error(sprintf('Exit code is %s.', ExitCode::GENERAL_ERROR->name));
@@ -666,7 +667,8 @@ trait AutoImports
array_merge($this->conversionMessages, $this->importMessages),
array_merge($this->conversionWarnings, $this->importWarnings),
- array_merge($this->conversionErrors, $this->importErrors)
+ array_merge($this->conversionErrors, $this->importErrors),
array_merge($this->conversionErrors, $this->importErrors),
- $this->conversionRateLimits
+ $this->conversionRateLimits,
+ $jsonFile
)
);
}
diff --git a/app/Events/ImportedTransactions.php b/app/Events/ImportedTransactions.php
index d0688f9..ec6f5be 100644
index 6e1dbb8..f8bef42 100644
--- a/app/Events/ImportedTransactions.php
+++ b/app/Events/ImportedTransactions.php
@@ -39,8 +39,9 @@ class ImportedTransactions
public array $errors;
@@ -40,8 +40,9 @@ class ImportedTransactions
public array $messages;
public array $warnings;
public array $rateLimits;
+ public string $fileName;

- public function __construct(array $messages, array $warnings, array $errors)
+ public function __construct(array $messages, array $warnings, array $errors, string $fileName = null)
- public function __construct(array $messages, array $warnings, array $errors, array $rateLimits)
+ public function __construct(array $messages, array $warnings, array $errors, array $rateLimits, string $fileName = null)
{
app('log')->debug('Created event ImportedTransactions with filtering (2)');

@@ -48,6 +49,7 @@ class ImportedTransactions
$this->messages = $this->filterArray('message(s)', $messages);
$this->warnings = $this->filterArray('warning(s)', $warnings);
$this->errors = $this->filterArray('error(s)', $errors);
+ $this->fileName = $fileName;
@@ -50,6 +51,7 @@ class ImportedTransactions
$this->warnings = $this->filterArray('warning(s)', $warnings);
$this->errors = $this->filterArray('error(s)', $errors);
$this->rateLimits = $this->filterArray('rate limit message(s)', $rateLimits);
+ $this->fileName = $fileName;
}

/**
diff --git a/app/Handlers/Events/ImportedTransactionsEventHandler.php b/app/Handlers/Events/ImportedTransactionsEventHandler.php
index ea1b918..b2ed846 100644
index b4205c8..d943090 100644
--- a/app/Handlers/Events/ImportedTransactionsEventHandler.php
+++ b/app/Handlers/Events/ImportedTransactionsEventHandler.php
@@ -58,6 +58,7 @@ class ImportedTransactionsEventHandler
'messages' => $event->messages,
'warnings' => $event->warnings,
'errors' => $event->errors,
+ 'fileName' => $event->fileName,
@@ -59,6 +59,7 @@ class ImportedTransactionsEventHandler
'warnings' => $event->warnings,
'errors' => $event->errors,
'rate_limits' => $event->rateLimits,
+ 'fileName' => $event->fileName,
];
if (count($event->messages) > 0 || count($event->warnings) > 0 || count($event->errors) > 0) {
app('log')->info('Will send report message.');
diff --git a/app/Mail/ImportReportMail.php b/app/Mail/ImportReportMail.php
index abd7591..bee8bed 100644
index a0e1dcf..3db9333 100644
--- a/app/Mail/ImportReportMail.php
+++ b/app/Mail/ImportReportMail.php
@@ -42,6 +42,7 @@ class ImportReportMail extends Mailable
public string $url;
@@ -44,6 +44,7 @@ class ImportReportMail extends Mailable
public string $version;
public array $warnings;
public array $rateLimits;
+ public string $fileName;

/**
* Create a new message instance.
@@ -57,6 +58,7 @@ class ImportReportMail extends Mailable
$this->errors = $log['errors'] ?? [];
$this->warnings = $log['warnings'] ?? [];
$this->messages = $log['messages'] ?? [];
+ $this->fileName = $log['fileName'] ?? "";
@@ -60,6 +61,7 @@ class ImportReportMail extends Mailable
$this->warnings = $log['warnings'] ?? [];
$this->messages = $log['messages'] ?? [];
$this->rateLimits = $log['rate_limits'] ?? [];
+ $this->fileName = $log['fileName'] ?? [];
}

/**
diff --git a/resources/views/v2/emails/import/report.blade.php b/resources/views/v2/emails/import/report.blade.php
index 048f786..da9bd73 100644
index 4d0128d..fc4f86b 100644
--- a/resources/views/v2/emails/import/report.blade.php
+++ b/resources/views/v2/emails/import/report.blade.php
@@ -48,5 +48,6 @@ Go to Firefly III
@@ -58,5 +58,6 @@ Go to Firefly III

Enjoy!<br>
Firefly III Data Importer, @if(str_starts_with($version, 'develop')){{ $version }} @else v{{ $version }}@endif
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
diff --git a/resources/assets/v1/src/components/transactions/EditTransaction.vue b/resources/assets/v1/src/components/transactions/EditTransaction.vue
index ed39dc47f0..edc6670930 100644
index 97fbf78f41..20232584f6 100644
--- a/resources/assets/v1/src/components/transactions/EditTransaction.vue
+++ b/resources/assets/v1/src/components/transactions/EditTransaction.vue
@@ -454,7 +454,7 @@ export default {
@@ -470,7 +470,7 @@ export default {
let result = {
transaction_journal_id: transaction.transaction_journal_id,
description: transaction.description,
- date: transaction.date.substring(0, 16),
+ date: transaction.date.substring(0, 19),
reconciled: transaction.reconciled,
amount: this.roundNumber(this.positiveAmount(transaction.amount), transaction.currency_decimal_places),
category: transaction.category_name,
errors: {

0 comments on commit d488ab4

Please sign in to comment.