Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (half)SipHash implementation #108

Merged
merged 4 commits into from
Jan 6, 2024
Merged

Add (half)SipHash implementation #108

merged 4 commits into from
Jan 6, 2024

Conversation

Entreco
Copy link
Contributor

@Entreco Entreco commented Jan 4, 2024

KMM implementation of (half)SipHash
Let me know your throughts, feedback, suggestions

Copy link
Contributor

@robxyy robxyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great but needs some minor tweaks.

@Entreco
Copy link
Contributor Author

Entreco commented Jan 5, 2024

Thanks for your quick review, much appreciated!
I've pushed the requested tweaks.

I am only able to run the tests on a Windows machine.
No clue if we need additional testing other (native) targets, I'll leave that up to you.

Btw, is it possible to add badges to the README with the supported platforms/targets?
Something like this should work I guess:

![badge-platform-android]
![badge-platform-jvm]
![badge-platform-js]

@robxyy
Copy link
Contributor

robxyy commented Jan 5, 2024

I am only able to run the tests on a Windows machine. No clue if we need additional testing other (native) targets, I'll leave that up to you.

Don't worry, Unit-tests passed. See runs

Btw, is it possible to add badges to the README with the supported platforms/targets? Something like this should work I guess:

![badge-platform-android]
![badge-platform-jvm]
![badge-platform-js]

LGTM, currently supports Tier 2

@robxyy robxyy merged commit e389204 into diglol:trunk Jan 6, 2024
@Entreco
Copy link
Contributor Author

Entreco commented Jan 8, 2024

Do you already know when you would like to publish a new version? No pressure, just curious :)

@robxyy
Copy link
Contributor

robxyy commented Jan 8, 2024

@Entreco v0.2.0 has been released and will be pushed to Maven in about 1 hour :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants