Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages and fix pylint issues in the ini file #1361

Merged
merged 1 commit into from
Apr 16, 2022

Conversation

ulliholtgrave
Copy link
Member

@ulliholtgrave ulliholtgrave commented Apr 15, 2022

Short description

This PR updates our JS and python packages to their newest version.

We should keep in mind that our setup.cfg will be deprecated by some point and we should consider switching to a pyproject.toml setup (see Issue #1362 ).

@ulliholtgrave ulliholtgrave requested a review from a team as a code owner April 15, 2022 23:01
@codeclimate
Copy link

codeclimate bot commented Apr 15, 2022

Code Climate has analyzed commit 52b961b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.1% (0.0% change).

View more on Code Climate.

Copy link
Member

@timobrembeck timobrembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

Do you have a resource that claims that setup.cfg is deprecated (soonish)? I know that pyproject.toml is the "new" format, but at the moment, it cannot replace setup.cfg, can it?
(it can just replace some of the configuration values, but at the moment this would just mean one additional file, I'm not sure whether that's an improvement...)

@ulliholtgrave ulliholtgrave force-pushed the update/js-and-py-packages branch from 05e9165 to 52b961b Compare April 16, 2022 07:45
@ulliholtgrave
Copy link
Member Author

I resolved all issues and created #1362 as a reminder to keep track of the current development in Setup Tools.

Copy link
Member

@timobrembeck timobrembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@ulliholtgrave ulliholtgrave merged commit 920cb60 into develop Apr 16, 2022
@ulliholtgrave ulliholtgrave deleted the update/js-and-py-packages branch April 16, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants