Configuration via environment variables #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, thanks for the update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full credits to @alles-klar for the original PR #592.
This PR adds the option of configuring DVWA via environment variables. This allows users to change the configuration without rebuilding the Docker image and is particularly useful in a Docker or Kubernetes deployment.
I believe this PR was incorrectly reverted in #605 and was not the cause of #604. The only issue in the original PR came from a mismatch between the environment variable name in config/config.inc.php.dist and in the README.md. The database server variable was changed from DB_SERVER to DVWA_DB_SERVER, which caused some confusion. I've kept the original name of the variable in this PR to avoid any breaking change.