Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu 22.04 release package #7502

Merged
merged 3 commits into from
Jan 27, 2023

Conversation

thomasspriggs
Copy link
Contributor

This PR adds a Ubuntu 22.04 a release package job.

Initially raised as a draft PR as the job is currently untested. The Ubuntu 22.04 binaries should already be tested as part of the Pull Request jobs.

A Ubuntu 22.04 package was requested here - #7474

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Because 22.04 is the current LTS release of Ubuntu.
Comment on lines 49 to 51
run: |
cd build
ninja -j2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit pick: we could save on vertical space by using ninja -C build -j2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. The job I added matched the existing packaged release jobs, so I updated the other Ubuntu package jobs as well.

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 78.48% // Head: 78.46% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (29d5c2c) compared to base (031ae2e).
Patch has no changes to coverable lines.

❗ Current head 29d5c2c differs from pull request most recent head cd3dd1e. Consider uploading reports for the commit cd3dd1e to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7502      +/-   ##
===========================================
- Coverage    78.48%   78.46%   -0.03%     
===========================================
  Files         1663     1663              
  Lines       191249   191249              
===========================================
- Hits        150103   150060      -43     
- Misses       41146    41189      +43     
Impacted Files Coverage Δ
src/big-int/bigint.hh 89.47% <0.00%> (-7.90%) ⬇️
src/big-int/bigint.cc 83.35% <0.00%> (-5.65%) ⬇️
src/util/symbol_table.cpp 89.13% <0.00%> (-2.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

In order to ensure better use of ccache.
Because this saves vertical space in the `.yaml` file.
@thomasspriggs thomasspriggs marked this pull request as ready for review January 26, 2023 17:25
@thomasspriggs thomasspriggs requested a review from a team as a code owner January 26, 2023 17:25
@thomasspriggs
Copy link
Contributor Author

What we have here seems reasonable to me. I propose that we merge this and see if it works next time we do a release. @NlightNFotis ?

@thomasspriggs thomasspriggs merged commit e0b348e into diffblue:develop Jan 27, 2023
@thomasspriggs thomasspriggs deleted the tas/Ubuntu2204_package branch January 27, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants