-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ubuntu 22.04 release package #7502
Add Ubuntu 22.04 release package #7502
Conversation
Because 22.04 is the current LTS release of Ubuntu.
run: | | ||
cd build | ||
ninja -j2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit pick: we could save on vertical space by using ninja -C build -j2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. The job I added matched the existing packaged release jobs, so I updated the other Ubuntu package jobs as well.
Codecov ReportBase: 78.48% // Head: 78.46% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7502 +/- ##
===========================================
- Coverage 78.48% 78.46% -0.03%
===========================================
Files 1663 1663
Lines 191249 191249
===========================================
- Hits 150103 150060 -43
- Misses 41146 41189 +43
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
In order to ensure better use of ccache.
Because this saves vertical space in the `.yaml` file.
What we have here seems reasonable to me. I propose that we merge this and see if it works next time we do a release. @NlightNFotis ? |
This PR adds a Ubuntu 22.04 a release package job.
Initially raised as a draft PR as the job is currently untested. The Ubuntu 22.04 binaries should already be tested as part of the Pull Request jobs.
A Ubuntu 22.04 package was requested here - #7474