PySide6 compatibility + new 4.2 modal_operators check in case event dies #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some new changes to work with PySide6 and Blender 4.2+.
The QT Event loop was causing seg faults when performing the New File action in tk-multi-workfiles2, as well as some other actions in other apps. To mitigate this, events are processed directly by the app rather than using an event loop. This fixes the crashes.
The event loop was also being killed after new file operations, so I've added a handler for load_post to create the event loop again if it has died. This does use the new window.modal_operators implemented with Blender 4.2 to ensure only one loop exists at a time, which would need to be handled in a different way for pre-4.2 compatibility.
Also includes changes from #18