Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: static_string #76

Merged
merged 7 commits into from
Mar 4, 2025
Merged

Feature: static_string #76

merged 7 commits into from
Mar 4, 2025

Conversation

liss-h
Copy link
Contributor

@liss-h liss-h commented Feb 21, 2025 •
edited
Loading

A fixed capacity heap allocated string type. (smaller than std::string)

@liss-h liss-h marked this pull request as ready for review March 4, 2025 10:46
@liss-h liss-h requested a review from bigerl March 4, 2025 10:48
bigerl
bigerl requested changes Mar 4, 2025
View reviewed changes
Copy link
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the PR. Code looks simple, nice and clean. I just have some cosmetic requests. See below.

@liss-h liss-h merged commit 001ae67 into develop Mar 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigerl bigerl bigerl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liss-h @bigerl