Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update add job route to match design specs #44

Merged
1 commit merged into from
Jul 21, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 13, 2020

Updating this route so it matches the design specs.

Todo:

Notes:

  • I've not focused on abstracting/organizing the components in pages yet (plus some of the form components), so there is duplication there. I'm planning to do that once the edit page has been built (which I'm doing next), since then it should be easier to see the patterns emerge.

@ghost ghost force-pushed the update-add-job-route branch from d001947 to 3e60fa9 Compare April 14, 2020 08:12
@ghost ghost force-pushed the remove-duplicate-components branch from 33a4c4a to a2fd083 Compare April 20, 2020 15:34
@ghost ghost force-pushed the update-add-job-route branch from 590ec04 to b1b92da Compare April 20, 2020 15:41
@ghost ghost changed the base branch from remove-duplicate-components to refactor-scheduler April 20, 2020 15:41
@ghost ghost force-pushed the update-add-job-route branch from b1b92da to ac39795 Compare April 20, 2020 15:41
@ghost ghost force-pushed the update-add-job-route branch from ac39795 to 92986c8 Compare June 22, 2020 14:50
@ghost ghost changed the base branch from refactor-scheduler to update-cli-style June 22, 2020 14:51
@ghost ghost force-pushed the update-cli-style branch from 027c362 to 1392733 Compare June 22, 2020 15:31
Base automatically changed from update-cli-style to refactor-scheduler June 22, 2020 15:37
@ghost ghost force-pushed the update-add-job-route branch from 1b6e1f8 to e101752 Compare June 25, 2020 12:24
@ghost ghost marked this pull request as ready for review June 25, 2020 12:34
@ghost ghost requested a review from awgaan July 16, 2020 08:14
Copy link

@awgaan awgaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid dedication shown here.
I was unable to find a single place where the implementation deviates from the design specs.
👏

@ghost
Copy link
Author

ghost commented Jul 21, 2020

Solid dedication shown here.
I was unable to find a single place where the implementation deviates from the design specs.
👏

😊 Thanks!

@ghost ghost force-pushed the update-add-job-route branch from 8811102 to 88ff826 Compare July 21, 2020 12:57
@ghost ghost merged commit b36cfd7 into refactor-scheduler Jul 21, 2020
@ghost ghost deleted the update-add-job-route branch July 21, 2020 13:04
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant