fix: period select fixes #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
turban
added a commit
that referenced
this pull request
Nov 20, 2019
turban
added a commit
that referenced
this pull request
Nov 20, 2019
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://jira.dhis2.org/browse/DHIS2-7839
This PR fixes 2 issues with the period selector:
Avoids crash if year is changed into the future, and then period type is changed. The crash happened because filterFuturePeriods would return an empty periods array as all of them would be in the future. If this is the case, we return the first period in the array.
If you select a period type, change the year, and then then change the tab, the period will no longer be selected. This PR fixes the issue by making sure the year is still the same, and not reset to the most recent year.
The long term plan is to switch to a shared period selector component, so I've tried to make as few changes as possible here, as the fix also needs to be backported.