feat: legend support for external layers (DHIS2-3201) #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turban
requested review from
edoardo,
janhenrikoverland,
jenniferarnesen and
martinkrulltott
dhis2-bot
added a commit
that referenced
this pull request
Dec 8, 2020
# [1.1.0](v1.0.3...v1.1.0) (2020-12-08) ### Features * legend support for external layers (DHIS2-3201) ([#1303](#1303)) ([2947dad](2947dad))
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://jira.dhis2.org/browse/DHIS2-3201
This PR adds legend support for external layers. The legend can be a predefined in DHIS2, or a url to a legend image.
This was already supported for external layers in the maintenance app:
Showing a predefined legend and a legend image in the maps app:
We don't control the design of an external layer image - the max-width is adjusted to the container.
The same legends shown for a plugin map (dashboard):
The logic for saving external layers is changed: Before we save the full layer config so we can recreate the layer from the analytical object alone. This is not sufficient when we now start to add additional capabilities to external layers. If the legend is updated this should be reflected on all saved maps using the layer. After this PR we will store the id of the external layer, and then fetch the latest layer config when the map is loading.