Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: event polygons #52

Merged
merged 7 commits into from
Apr 8, 2019
Merged

feat: event polygons #52

merged 7 commits into from
Apr 8, 2019

Conversation

turban
Copy link
Contributor

@turban turban commented Apr 3, 2019

Fixes: https://jira.dhis2.org/browse/DHIS2-3164

Associated PR for the Maps app: dhis2/maps-app#114

Main changes:

  • "Dots" layer replaced with "Events" layer supporting both points and polygons
  • New "Polygon" feature allowing us to create polygons from GeoJSON features
  • Buffers gets the same color as the features it surrounds
  • Cleaning up popup handling
  • Add polygon support to client clusters
  • Add polygon support to server clusters
  • Allow event polygons to be buffered (reusing code from TEIs)

@turban turban changed the title *WIP* Event polygons Event polygons Apr 4, 2019
@turban turban requested a review from amcgee April 4, 2019 16:00
@amcgee
Copy link
Member

amcgee commented Apr 4, 2019

First glance looks good to me. The new Events layer type isn't actually used by TEI layers though right? Should it be?

@turban
Copy link
Contributor Author

turban commented Apr 4, 2019

The new Events layer type isn't actually used by TEI layers though right? Should it be?

Currently not, as we don't support color per features for TEIs yet. When we do, we can easily swith. Will also try to make this cleaner in the new Maps GL lib.

@amcgee amcgee changed the title Event polygons feat: event polygons Apr 8, 2019
Copy link
Member

@amcgee amcgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

@turban turban merged commit c2debad into master Apr 8, 2019
@turban turban deleted the feature/DHIS2-3164 branch April 8, 2019 19:06
dhis2-bot added a commit that referenced this pull request Dec 10, 2020
# [31.1.0](v31.0.3...v31.1.0) (2020-12-10)

### Bug Fixes

* fitbounds, on layergroup and in general ([0e83006](0e83006))
* load EarthEngine directly from node_modules browser build ([#50](#50)) ([020ea5f](020ea5f))
* override circle getBounds before map is bound ([#54](#54)) ([481c187](481c187))
* support index re-ordering ([20975bc](20975bc))

### Features

* event polygons ([#52](#52)) ([c2debad](c2debad))
* export map control types ([#74](#74)) ([71e597a](71e597a))
* export supported layer types ([#73](#73)) ([6bde95c](6bde95c))
* layer types as static method ([#66](#66)) ([bb124bf](bb124bf))
* support generic layer group ([89d9156](89d9156))
* synced maps support ([#58](#58)) ([0cd7eae](0cd7eae))
* synchronize the view of two maps ([#56](#56)) ([7dbffe3](7dbffe3))
* translate options to leaflet syntax ([#75](#75)) ([f1a3245](f1a3245))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 31.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants