fix: confirm dialog with interpretation view #1270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since no change is actually lost when navigating in and out of an interpretation's view, remove the confirm dialog. Also, when answering No to the confirm dialog (meaning i don't want to navigate to the new URL) restore the previous URL with history.goBack() so that the app really is in the same state as before the confirm dialog.
|
Integrated into #1273 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes here are for improving when the navigation confirm dialog is shown and what happens when clicking Yes or No.
Since there is actually no change loss when navigating in and out of an interpretation's view, the confirm dialog does not show, even if there are changes to the visualization.
When answering No to the confirm dialog, the previous URL is loaded so that the state of the app is really what it was before.