feat(eslint): add react a11y plugin

[ghost]

This adds https://www.npmjs.com/package/eslint-plugin-jsx-a11y and enables the recommended preset. The plugin also ships with a strict preset, but I thought that starting out permissive is probably nicer for consumers of cli-style.

[HendrikThePendric]

This plugin is also very good to add, but I think that with the recommended settings enabled this is going to cause havoc in existing apps which typically do very poorly on a11y.

The recommended settings will throw errors so after upgrading cli-style the app dev will have to fix ALL a11y issues before the code can be merged.

If this plugin has the ability to fix the issues it detects, I think this would be much less of a problem, but I don't know if this is possible and expect it isn't.

So perhaps we should include this plugin but only throw warnings?

[HendrikThePendric]

I thought that starting out permissive is probably nicer for consumers of cli-style.

The recommended preset doesn't appear to be very permissive 😒 .

[ghost]

I thought that starting out permissive is probably nicer for consumers of cli-style.

The recommended preset doesn't appear to be very permissive 😒 .

Hmm yeah that's not as permissive as I'd like. Ok, I'll see if I can come up with something more permissive.

[ghost]

I took a look, but I'm not sure what the best approach would be here. I could set all the recommended rules to warn (depending on whether we eventually want to go with warn for cli-style or not). Or we could start with a couple of rules and set those to errors. But I'm not sure which rules would be most important to us.

I haven't encountered any errors with the scheduler, which made me think that it's fairly permissive, but it does actually have a fair amount of rules that can error out. Ideas?

[varl]

We can make this opt in to add, so we'd do e.g. d2-style add eslint react-a11y to enable it, so apps can choose when to let havoc be wrought.

[ghost]

We can make this opt in to add, so we'd do e.g. d2-style add eslint react-a11y to enable it, so apps can choose when to let havoc be wrought.

Yeah that sounds good to me. That way we can keep the config simple by just following the recommended settings.

[stale]

Hi!

Due to a lack of activity on this issue over time (180 days) it seems to be stale. If still relevant, please provide information that moves it forward, e.g. additional information, a pull request with suggested changes, or a reason to keep it open.

Any activity will keep it open, otherwise it will be closed automatically in 30 days. Thanks! 🤖

[stale]

Automatically closing due to lack of activity. 🤖