-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add documentation for useTimeZoneConversion [LIBS-396] #1328
Conversation
Thanks for the review @Topener. I have fixed the code examples (and added a note to the last one to make it clearer that it is purely an example and shouldn't be copy/pasted). Would you like to try doing the rewording for the points that you thought could benefit? I think the time zone issues are a bit complicated to communicate in a clear manner, so maybe it would benefit from your attempts to reformulate? Thanks |
@tomzemp yes I'll get on that! Thanks for the improvements |
@tomzemp I've improved the text some, please check if I didn't break anything flow wise, otherwise we're good |
Great. Thanks @Topener 🙏. Could you run prettier on that file as it's now failing the lint check? |
🎉 This PR is included in version 3.9.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Adds documentation for the
useTimeZoneConversion
hook.I have tried to cover most applicable use cases without too much additional explanation.
Some other points (like javascript dates sucking and this hopefully becoming irrelevant when temporal is released) might be handled in a blog post @Topener? FYI: The original ticket (LIBS-396) and the PR for the code also has a lot of background discussion.