Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add documentation for useTimeZoneConversion [LIBS-396] #1328

Merged
merged 6 commits into from
Feb 17, 2023

Conversation

tomzemp
Copy link
Member

@tomzemp tomzemp commented Feb 13, 2023

Adds documentation for the useTimeZoneConversion hook.

I have tried to cover most applicable use cases without too much additional explanation.

Some other points (like javascript dates sucking and this hopefully becoming irrelevant when temporal is released) might be handled in a blog post @Topener? FYI: The original ticket (LIBS-396) and the PR for the code also has a lot of background discussion.

@tomzemp tomzemp requested review from Topener and a team February 13, 2023 13:45
@tomzemp
Copy link
Member Author

tomzemp commented Feb 14, 2023

Thanks for the review @Topener. I have fixed the code examples (and added a note to the last one to make it clearer that it is purely an example and shouldn't be copy/pasted).

Would you like to try doing the rewording for the points that you thought could benefit? I think the time zone issues are a bit complicated to communicate in a clear manner, so maybe it would benefit from your attempts to reformulate?

Thanks

@Topener
Copy link
Contributor

Topener commented Feb 14, 2023

@tomzemp yes I'll get on that! Thanks for the improvements

@Topener
Copy link
Contributor

Topener commented Feb 15, 2023

@tomzemp I've improved the text some, please check if I didn't break anything flow wise, otherwise we're good

@tomzemp
Copy link
Member Author

tomzemp commented Feb 15, 2023

Great. Thanks @Topener 🙏. Could you run prettier on that file as it's now failing the lint check?

@tomzemp tomzemp merged commit ca52210 into master Feb 17, 2023
@tomzemp tomzemp deleted the LIBS-396/useTimeZoneConversion-documentation branch February 17, 2023 08:29
@dhis2-bot
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants