Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Localization not implemented for ColorPicker/Option #54

Closed
Nilon123456789 opened this issue Apr 9, 2024 · 4 comments
Closed

[BUG] Localization not implemented for ColorPicker/Option #54

Nilon123456789 opened this issue Apr 9, 2024 · 4 comments
Assignees
@dheid
Labels
bug Something isn't working

Comments

@Nilon123456789
Copy link
Contributor

Describe the bug
The ColorPicker class is not using localization.

Code snippets

ResourceBundle.getBundle("com.bric.colorpicker.resources.ColorPicker"); // This is not calling the getBundle with a local.

Expected behavior

ResourceBundle.getBundle("com.bric.colorpicker.resources.ColorPicker", local); // local being the current active localization
@Nilon123456789 Nilon123456789 added the bug Something isn't working label Apr 9, 2024
@dheid
Copy link
Owner

dheid commented Apr 9, 2024

Thx for opening this issue! I will look at it, when I have time.

@Nilon123456789
Copy link
Contributor Author

Alright, I might if I have time make a pull request with a fix ready

Nilon123456789 added a commit to Nilon123456789/colorpicker that referenced this issue Apr 10, 2024
@Nilon123456789
ADD : Localization support for all components
340db87 
Linked to issue dheid#54
@Nilon123456789 Nilon123456789 mentioned this issue Apr 10, 2024
Merged
6 tasks
@Nilon123456789
Copy link
Contributor Author

I've created a pull request with a working fix. Feel free to edit it or suggest me modifications.

dheid added a commit that referenced this issue Apr 19, 2024
@dheid
Merge pull request #55 from Nilon123456789/Localization
aaa5c47 
Localization support (Issue #54)
@dheid
Copy link
Owner

dheid commented Apr 19, 2024

Thx so much! New release 2.0.0 with your contribution is on it's way.

@dheid dheid closed this as completed Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dheid dheid

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dheid @Nilon123456789