bump agent-js to 0.15.4 #2033
Merged
bump agent-js to 0.15.4 #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
peterpeterparker
added a commit
that referenced
this pull request
Mar 7, 2023
# Motivation Validate Bitcoin address according selected network on send. # PRs - [x] dfinity/ic-js#300 # Note UX wise, the feature is not completed with this PR. In another PR we will have to select the network according the input. e.g. input field is empty, user enter a BTC adress, dropdown is automatically selected with BTC network # Changes - add Btc address checks to function `invalidAddress` - refactor ICP / Icrc related checks to `invalidICPOrIcrcAddress` to not introduce changes where not needed - validate input address on network change - add testnet and mainnet granularity to `TransactionNetwork` because bitcoin address are different on these networks - bump ic-js and agent-js (which should pass first in another PR #2033) # Screenshots <img width="1536" alt="Capture d’écran 2023-03-07 à 07 43 53" src="https://user-images.githubusercontent.com/16886711/223344358-144272f4-8b43-4067-b435-772b7ad69394.png"> <img width="1536" alt="Capture d’écran 2023-03-07 à 07 44 04" src="https://user-images.githubusercontent.com/16886711/223344382-876d4513-8b02-4e7f-a0cc-e6eecab9e1a6.png"> <img width="1536" alt="Capture d’écran 2023-03-07 à 07 44 16" src="https://user-images.githubusercontent.com/16886711/223344408-cfbc196f-c05b-46e0-b332-c86b17e5c1f2.png"> <img width="1536" alt="Capture d’écran 2023-03-07 à 07 44 22" src="https://user-images.githubusercontent.com/16886711/223344416-8e48819a-8d50-47db-87dc-a4713314765d.png"> <img width="1536" alt="Capture d’écran 2023-03-07 à 07 44 25" src="https://user-images.githubusercontent.com/16886711/223344425-2c82ba0d-e666-432a-b88f-95301e893ebf.png">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The new agent-js release has fewer circular dependencies which helps build reproducibility because of rollup/plugins#1425.
Changes
npm run update:agentTests
Clicked around a bit on testnet.